This is bugging me for quite some time now with Hackernews and other aggregator feeds submitting links to NPR, CNN, Guardian and other bullshit i won’t know unless i actually open the link.
The change is minimal (~20 lines) and looks like this:
The field is only visible if m_article.comments_link hostname is different from m_article.link hostname, omitting the www. prefix if present.
Your CONTRIBUTE.md is not entirely clear since you don’t even run Gog (any more?) and i can’t fork https://gitlab.tt-rss.org/tt-rss/tt-rss-android (project limit), do you even accept PRs?
Cheers
1 Like
fox
May 20, 2023, 7:49am
2
sounds like a good idea to me.
https://gitlab.tt-rss.org/tt-rss/tt-rss/-/blob/master/CONTRIBUTING.md#contributing-code-the-right-way
tldr: you tell me you gitlab account, i’ll give it proper rights, and you’ll be able to clone stuff and make PRs.
e: i forgot that tt-rss-android has a separate contributing.md, i’ll make a note to update it to be more relevant.
fox
May 20, 2023, 11:36am
4
done.
i would rather have a more streamlined flow here but unfortunately dozens of bots register per day and just flood everything with spam.
defkev
May 20, 2023, 12:45pm
5
Would you consider updating the tt-rss API getArticle to include the feed_url property?
I’d rather use that (if available) and comments_link (which may or may not be available) as a fallback.
fox
May 20, 2023, 1:22pm
6
i don’t see why not. don’t forget to bump API version if you plan to make a MR for this.
e: probably site_url not feed_url, i would assume feed_url having feed XML url
Done, site_url works even better.
Edit:gitlab.tt-rss.org ^^
fox
May 21, 2023, 5:17am
8
oh boy. can’t live with antispam, can’t live without it…
fox
May 21, 2023, 5:19am
9
apparently there’s a whitelist for this rule (should i add something else here maybe? idk)
defkev
May 21, 2023, 8:49am
10
Just noticed i missed the configurable font size
