Session.cookie_lifetime is always 0

Looking at the code

ini_set("session.cookie_lifetime", min(0, SESSION_COOKIE_LIFETIME));

this will always be 0. is that intentional?

yes, it can be simply 0. i don’t remember why it’s written in this particular way, 2013 was a while ago.

I think their point is that it’s min rather than max. So unless SESSION_COOKIE_LIFETIME is negative that’s always going to result in 0.

If anyone wants SESSION_COOKIE_LIFETIME to have effect that would need to be max(0, SESSION_COOKIE_LIFETIME).

that would make every login a “remember me” one.

e: https://git.tt-rss.org/fox/tt-rss/commit/da5deaaca18f7affe982368572179ba78815eb4e