Hi,
is there a limit to the number of icons added by the HOOK_ARTICLE_BUTTON hook ?
I actually have “close_button” “mailto” “share” “yourls” “shaarli” plugins activated, and since a few months (how many, I don’t know ?) I can see only the 3 first one.
I primarily think about a change that disabled or errored the other plugins, but then I tried to change the hook_article_button() function of a disappeared plugin to be equivalent to the workin’ one. The result is that a new button appeared, but another one disappeared.
And after a lot of changes, it seems that only 3 buttons could appears.
Am I doing something bad, or missed a documentation point, or?
FYI: tt-rss is running on an old fashioned LAMP server, php7.4, via git and up-to-date.
Tanks for any advices,
GT
fox
2
no, there’s no limit. most likely you’re running into markup issues with older plugins.
https://community.tt-rss.org/t/article-wallabag-button-disappeared/5132
e: i’m going to add a warning if something in this hook fails on markup because currently it’s not obvious:
https://git.tt-rss.org/fox/tt-rss/commit/c3482fbe6b22885f5619df02387de09be0886cfe
Oh wow, cool stuff. And quick response, as usual.
(and yes, I have a lot of work, because my old plugins are all f**d up)
Thx!
fox
4
since most plugins are copy-pasted from each other, it’s very likely that adding closing tags or something trivial like that would fix them all.
e: i guess what i’m saying is that its really-really unlikely you’ll run into any complicated issues there.
Correct. Same modification to “share to Shaarli”, “share to Yourls”, and your very-old-not-maintained “share to Twitter”. It seems that some have copied the last one.
Thx again.
