Class autoloader has been updated to support the above, incidentally we can now load namespaced third party libraries with zero additional bullshit (should’ve done this long time ago tbh)
Just tried the new readability library. It seems to work a lot better than the other one. This even removes a good amount of the garbage sites put in the middle of their articles (related stories, etc.).
check nginx error.log for errors, also try going to older changesets until things start working again and then check tt-rss error log in preferences for errors.
anything non-stock in config.php like auth modules?
Issue: feed using readability to inline content causes the following error to be recorded.
PHP Parse error: syntax error, unexpected 'class' (T_CLASS), expecting identifier (T_STRING) or variable (T_VARIABLE) or '{' or '$' in /home/feeds/ttrss/vendor/andreskrey/Readability/Nodes/DOM/DOMDocument.php on line 15
I’m using php 5.4 (because that’s what centos 7 provides by default), and I suspect that’s the root cause, as the readability.php specifies 5.6 as its minimum. I’m still working to confirm.
Assuming this is right, it might be best to adjust the documented php requirements up to 5.6.
Definitely overkill… but! All the classes are abstracted anyway so you could just have a is_compatible() method. In the parent class it just returns true and then individual plugins can override it and run their own checks. TT-RSS proper would just call af_readability->is_compatible() when the plugin is enabled and if it returns true it enables it, false it does not.
yeah this is actually a good idea, alternatively af_readability can check php version in init an post a warning / don’t install any hooks if php < 5.6.