1
  • [x] I’m not using docker on my primary instance.

I’m using the daily summary email and noticed that at some point in the last few days formating of that email does not fit anymore.
In the past it was Content-Type: text/plain; charset=UTF-8 now it is Content-Type: text/html; charset=UTF-8 but as there are no html-tags in the mail at all my client just bunches the whole content up in one line.

2

blame this guy - #72 - minor: Support html content in mailer.php - tt-rss - Tiny Tiny RSS :slight_smile:

i’ll make a note to take a look at this.

3

alright. i’m not seeing anything wrong with the digest:

image
image848×482 68.2 KB

^ html version in roundcube

image
image691×394 41.1 KB

^ plain text version in mutt

additionally,

  • digest has had both html and plain text versions for a long time now;
  • i’m not seeing anything wrong with the above PR code, if it enabled sending multi-part messages for the digest this was actually fixing a bug, because you were seeing wrong content-type before;
  • briefly glancing over generated email i’m not seeing anything wrong either - it’s a multipart which has has both text/plain and html parts, both seem to render fine (screenshots above);
  • you haven’t specified which MUA you’re using but it might be malfunctioning;

p.s. i’m testing using mailer_smtp plugin. the above PR changes behavior for the fallback sending via mail(). oops.

4

image
image741×156 25.3 KB

5

image

I use roudcube myself and the plain-text-view shows quirky linebreaks while the html-view has no clickable links and linebreaks at all.
I am missing multipart somehow. Is that configurable somewhere?

6

In the past it looked something like this:
image

7

in the past, mail() fallback didn’t support html mail at all, thus the change.

maybe I’ve used mail() incorrectly for mime messages or maybe it’s php version dependent, since you’re using docker. my dev environment is also container-based so i can’t really test this.

anyway,

  • switch to mailer_smtp, it sends proper multipart messages which would fix your digest problem. you’ll need to do some basic configuration i.e. smtp server, etc, depending on your environment;
  • as for mail() fallback, maybe the PR should be reverted and fallback would stay plain-text only with mailer_smtp plugin available if you need better messages;
  • using mail() doesn’t make a lot of sense in a container environment, so maybe the fallback should be removed from the core entirely (if nothing else, because i can’t test it) and/or moved to a separate unsupported plugin;

i’ll think this over.

e: i’m leaning towards removing the fallback, mailer_smtp is simply better in every way, and you control delivery path entirely instead of relying on however the server is set up.

e2: also the PR is wrong, i think, message should be formed with multipart/alternative, he’s pushing text/html with plain text body. did he even test this? no, he didn’t. reverting.

the fallback stays for the time being, limited to plain text.

8

Im’ not using docker.
I will check out mailer_smtp plugin and try to get it working.
Thank you for the quick feedback.

9

your digest should be back to normal with the PR reverted, unless you want to try html digest you can just keep everything as it was.

10

added mailer_smtp in PLUGINS
as well as LOGIN and PASSWORD
and adjusted SERVER (was localhost before)

//config.php
...
putenv('TTRSS_PLUGINS=auth_internal, mailer_smtp, note');
putenv('TTRSS_SMTP_FROM_NAME=Tiny Tiny RSS');
putenv('TTRSS_SMTP_FROM_ADDRESS=rss@domain.xy');
putenv('TTRSS_SMTP_SERVER=domain.xy:465');
putenv('TTRSS_SMTP_LOGIN=mail@domain.xy');
putenv('TTRSS_SMTP_PASSWORD=p4ssw0rd');
...

i think it uses still the fallback :thinking:

11

mailer_smtp :see_no_evil: was not installed.
Everything working now with correctly formated multipart mails.
nice :+1: