Tiny Tiny RSS: Community

Next article or scroll doesn't work in Combined mode anymore

Describe the problem you’re having:


I was running 8e8fd73db and updated to latest master 47135160d, and I have the plugin googlereaderkeys enabled.

$ git log --oneline 8e8fd73db..HEAD | wc -l
144

After the update the space bar only scrolled the paged, never jumped to next article.
Looking av the Web Console in Firefox i saw next_article did not exist anymore. After looking at the code is seams to be replaced by next_article_or_scroll.

I changed the the following line in plugins/googlereaderkeys/init.php

$hotkeys[" |Space"]     = "next_article";

to

$hotkeys[" |Space"]     = "next_article_or_scroll";

But still it only scroll and don’t jump to next article,
In the Web Console I can see it trigger next_article_or_scroll, but cur stays the same but `next" increase

keyeventToAction   => next_article_or_scroll AppBase.js:161:12
cur: 515063 next: 515065                     Headlines.js:876:12
keyeventToAction   => next_article_or_scroll AppBase.js:161:12
cur: 515063 next: 515067                     Headlines.js:876:12
keyeventToAction   => next_article_or_scroll AppBase.js:161:12
cur: 515063 next: 515088                     Headlines.js:876:12
keyeventToAction   => next_article_or_scroll AppBase.js:161:12
cur: 515063 next: 515105                     Headlines.js:876:12
keyeventToAction   => next_article_or_scroll AppBase.js:161:12
cur: 515063 next: 515119                     Headlines.js:876:12

Platform (i.e. Linux distro, PHP, PostgreSQL, etc) versions:


Firefox 71 on Linux
Also tried a clean profile without any plugins but with the same result.

PHP 7.2
Apache 2.4.29

i have never used this plugin so i don’t know how its supposed to work exactly.

this (scroll down/up and/or jump to article) behavior is gone from trunk.