1

In my event log:

E_DEPRECATED (8192) classes/urlhelper.php:70 --> idn_to_ascii(): INTL_IDNA_VARIANT_2003 is deprecated

PHP Version 7.3.24
Debian 10

Perhaps replacing the code block (starting at line 67, but specifically line 70) with the following corrects the warning?

		//convert IDNA hostname to punycode if possible
		if (function_exists("idn_to_ascii")) {
			if (mb_detect_encoding($tokens['host']) != 'ASCII') {
				if (defined('IDNA_NONTRANSITIONAL_TO_ASCII') && defined('INTL_IDNA_VARIANT_UTS46')) {
					$tokens['host'] = idn_to_ascii($tokens['host'], IDNA_NONTRANSITIONAL_TO_ASCII, INTL_IDNA_VARIANT_UTS46);
				} else {
					$tokens['host'] = idn_to_ascii($tokens['host']);
				}
			}
		}
2

sure, can you file a PR?

3

Apologies but I’ve never done a pull request before on any code base. Hope you’ll still consider the contribution.

4

it’s not hard or anything but if you don’t want to bother with gogs i’ll just make the change myself, probably tomorrow. thanks for the fix.

5

https://git.tt-rss.org/fox/tt-rss/commit/328d7b55c8cb4d56492356a73df19f7c59784d82

not tested, going to assume this works :slight_smile: