Tiny Tiny RSS: Community

Errors not reported for feeds fetched via http2

Describe the problem you’re having:
When a feed is fetched via HTTP/2 errors are not reported in the UI.
This is because of https://git.tt-rss.org/fox/tt-rss/src/master/include/functions.php#L300, which assumes HTTP1.* as the HTTP version. Since curl learned to speak http2 that assumption is no longer valid. HTTP/2 and HTTP/2.0 can both be found in the wild.

tt-rss version (including git commit id):
commit id: ffb842f75

Platform (i.e. Linux distro, PHP, PostgreSQL, etc) versions:
php 7.3.10
postgresql 11.5

well, maybe this should match to ‘http/’ or something then?

e: alternatively i could probably set curl to ask for http/1.1 since in the end it doesn’t make much difference when you’re doing one off requests.

Might want to future proof it? We’re going to get http/3 soon which will use udp rather than tcp. It’s possible that a few years down the line from that people will stop using tcp, and thus http/1.1 completely if the deprecation of tlsv1.0/v1.1 is anything to go by.

you don’t say.

deprecation of tls is forced because of security, there’s no such concerns with http.

tldr: wake me up when any of this happens.

Both solutions seems fine to.
But I think I foresee someone complaining about tt-rss not using http2 …