6

as usual for google the documentation is literal garbage

“here’s a way to get all browsers which implement custom tabs, you should use the preferred one, no we are not going to tell you how to figure out which one is preferred”

okay, time to snack overflow, as usual

5 minutes later

“You may want to check ResolveInfo#preferredOrder to check if the user has preference on one of the apps over the others. Also, if there’s no preferred app (or two apps have the same major preference level), you may want to ask the user to choose one, or go with reasonable defaults”

preferredOrder
added in API level 1
int preferredOrder
Order of result according to the user's preference. If the user has not set a preference for this result, the value is higher values are a higher priority.

oh god so they want me to sort this list by this field or something because some alpha ubersperg might have a cascading priority list of fucking browsers (i can’t even imagine how would you set something like that in android UI)

sorry boys gonna file this as “maybe later, when i’m too bored to function” for the time being, merge requests are welcome

7

thanks to https://git.tt-rss.org/git/tt-rss-android/pulls/3 new beta build with this should be up soon

i don’t have firefox installed so someone else will have to test if this actually works like it should

8

I just tried the beta and this feature works correctly. Thanks.

9

Tried the beta, seems to work as expected with Firefox Focus. Thanks Fox.

10

gonna push this to prod then

thank the guy who submitted the PR, i’d never bother myself

11

Thanks feuerplatz… :slight_smile:

12

I installed on 2 devices this AM and on both when I launch I just get a black screen. Samsung Galaxy 8+ and a Chromebook Android environment.

13

app doesn’t load at all? uhoh

14

looking by my crash reports its like everything is completely and utterly fucked on some devices

nice

e: 2017-11-21 (897 crashes, 29 unique installs) - posted crash to the PR

i’ve pushed an update which reverts this change to production, i guess we had to test it just a bit more lol

we’re at 1000 crashes now

15

It’s just a guess, but I think the crash happens when getCustomTabPackageName() returns null. Maybe check if it’s null and return "com.android.chrome" instead?

16

pls post this on the PR, not sure if author reads this thread

17

i think you’re right, if i set this manually to null i get the exact same exception on the avd

it’s probably this:

		if (packagesSupportingCustomTabs.isEmpty()) {
			s_customTabPackageName = null;

i’m not sure why would this list be empty (no chrome installed? who cares) but it’s fairly obvious that this function should either never return null or null value shouldn’t be used if returned, personally i would just default to chrome package in this case.

https://git.tt-rss.org/git/tt-rss-android/commit/bf5528dd5e245276af373b615d35c1f18b98f769

i wonder if i should wrap this in try-catch too just in case tbh

18

Can we get a beta release that enables this again?

19

yeah, sorry, i was busy with other stuff. i’ll try to put a beta up tomorrow.

20

new beta (1.230) should be up soon

sorry for the delay

21

I just tried it and it seems to work just fine calling Firefox Focus instead of Chrome.

22

let’s not rush it this time :slight_smile:

23

works fine for me too – Android 7 with Firefox Focus as default browser

I am not sure, did the color change slightly?

e: just compared with my tablet, the new version has a more saturated blue – I think both are fine :grinning:

24

some slight css changes are coming with the pdo changeover, this just unifies the colors

25

well i’m not seeing any unusual crashes so i’m going to slowly start rolling this out to stable

fingers crossed, etc